Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix fabric8io#3144: making the crud mock logic more crd aware #3156

Merged
merged 1 commit into from
Jun 8, 2021
Merged

fix fabric8io#3144: making the crud mock logic more crd aware #3156

merged 1 commit into from
Jun 8, 2021

Conversation

shawkins
Copy link
Contributor

@shawkins shawkins commented May 21, 2021 •
edited
Loading

Description

#3144 this adds broader crd awareness to the mock server - primarily for determining if status is a subresource. If there is no crd, it's assumed that status is not a subresource.

There's also a minor change to not send events from patches that result in no changes to the resource.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change
  • Chore (non-breaking change which doesn't affect codebase;
    test, version modification, documentation, etc.)

Checklist

  • Code contributed by me aligns with current project license: Apache 2.0
  • I Added CHANGELOG entry regarding this change
  • I have implemented unit tests to cover my changes
  • I have added/updated the javadocs and other documentation accordingly
  • No new bugs, code smells, etc. in SonarCloud report
  • I tested my code in Kubernetes
  • I tested my code in OpenShift

@shawkins shawkins requested review from manusa and rohanKanojia May 21, 2021 11:22
@centos-ci
Copy link

Can one of the admins verify this patch?

@shawkins shawkins mentioned this pull request May 21, 2021
Closed
This was referenced May 31, 2021
Closed
Merged
@rohanKanojia
Copy link
Member

@Fabian-K : Could you please review this PR whenever you find time?

@shawkins
Copy link
Contributor Author

shawkins commented Jun 4, 2021

This does not address #3216 and a lot of the mock logic can evolve after #3185

Fabian-K
Fabian-K approved these changes Jun 7, 2021
View reviewed changes
Copy link
Contributor

@Fabian-K Fabian-K left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good from my point of view. Thanks!

@shawkins shawkins added this to the 5.5.0 milestone Jun 7, 2021
@shawkins
fix fabric8io#3144 fabric8io#3194: making the crud mock logic more cr…
17104b0 
…d aware

also working around making the namespace and kind available from the
path
@shawkins
Copy link
Contributor Author

shawkins commented Jun 7, 2021

Rebased, and updated the changelog for #3194

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 7, 2021

SonarCloud Quality Gate failed.

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

68.4% 68.4% Coverage
0.0% 0.0% Duplication

manusa
manusa approved these changes Jun 8, 2021
View reviewed changes
Copy link
Member

@manusa manusa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thx!

@manusa manusa merged commit 9e83908 into fabric8io:master Jun 8, 2021
@shawkins shawkins mentioned this pull request Sep 11, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rohanKanojia rohanKanojia rohanKanojia approved these changes

@Fabian-K Fabian-K Fabian-K approved these changes

@manusa manusa manusa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
5.5.0
Development

Successfully merging this pull request may close these issues.
5 participants
@shawkins @centos-ci @rohanKanojia @manusa @Fabian-K